feat(forkJoin): accept array of observable as parameter #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
feat-forkjoinarray
branch
from
8da1876
to
d5190f7
Compare
| const sources = this.sources; | ||
| let resultSelector: (...values: Array<any>) => any = null; | ||
| if (typeof sources[sources.length - 1] === 'function') { | ||
| resultSelector = sources.pop(); |
There was a problem hiding this comment.
Appreciate for suggestion of mutating sources directly @Blesh , this seems way better than I did originally. I should've tried to look existing references before submitting PR.
kwonoj
force-pushed
the
feat-forkjoinarray
branch
from
d5190f7
to
5611d0a
Compare
| // if the first and only other argument besides the resultSelector is an array | ||
| // assume it's been called with `forkJoin([obs1, obs2, obs3], resultSelector)` | ||
| if (sources.length === 1 && isArray(sources[0])) { | ||
| sources = <Array<Observable<any>>>sources[0]; | ||
| } |
There was a problem hiding this comment.
Seems previous comment went away by updating. Appreciate @Blesh for suggestion, it seems much better than I did first time. :)
kwonoj
force-pushed
the
feat-forkjoinarray
branch
from
5611d0a
to
4c1abf7
Compare
|
Updating code lint-friendly makes one comment goes away :( I should buy mac.
Updated perf shows quite similar to original code |
|
Merged with 7f892ad after minor lint fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #594
This PR enables
forkJoinaccepts array of observable.Creating overloads of function having array parameter to rest parameter requires some explicit unfolds due to behaviors of typescript (bit more explanation can be found here, way I used can be found in this PR as well.)
Performance wise, I haven't noticed big impact for general usecases of using rest parameters.
(numbers may vary). Checking typeof array for single observable, or array might impact bit more though.
before
after